Repository navigation
feat: fetch apps and collaborators (WPB-25747) - #5220
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5220 +/- ##
========================================
Coverage 54.15% 54.16%
========================================
Files 756 756
Lines 26446 26451 +5
Branches 4374 4377 +3
========================================
+ Hits 14322 14326 +4
+ Misses 10726 10725 -1
- Partials 1398 1400 +2
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
Contributor
Test Results10 files - 337 10 suites - 337 7s ⏱️ - 1m 44s Results for commit 2353944. ± Comparison against base commit 049fd33. This pull request removes 2771 tests.♻️ This comment has been updated with latest results. |
yamilmedina
approved these changes
Aug 27, 2026
sbakhtiarov
force-pushed
the
feat/apps-and-collaborators-fetch
branch
from
September 21, 2026 07:30
990b69e to
b6dfe43
Compare
sbakhtiarov
force-pushed
the
feat/apps-and-collaborators-fetch
branch
from
September 22, 2026 07:30
b6dfe43 to
2731374
Compare
ohassine
approved these changes
Sep 22, 2026
sbakhtiarov
enabled auto-merge
September 23, 2026 06:53
sbakhtiarov
force-pushed
the
feat/apps-and-collaborators-fetch
branch
from
September 23, 2026 06:53
0778583 to
2353944
Compare
Contributor
|
@sbakhtiarov looks like you are rolling back kalium to a previous commitish. This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.
Is this intentional? |
sbakhtiarov
force-pushed
the
feat/apps-and-collaborators-fetch
branch
from
September 23, 2026 16:38
2353944 to
91628bd
Compare
Contributor
|
APKs built during tests are available here. Scroll down to Artifacts! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/WPB-25747
https://wearezeta.atlassian.net/browse/WPB-25747
What's new in this PR?
Issues
The Apps search relied on locally cached users, which can be incomplete for teams with more than 2,000 members. This could incorrectly show an empty Apps page even though apps were available.
Solutions
Refresh apps once when the Apps page is opened and wait for the refresh before resolving the initial empty-query results. Subsequent searches use the refreshed local cache without repeating the synchronization.
If refreshing fails, log the failure and continue using the existing cached apps.
When apps are disabled for the conversation, render the disabled-state content directly without creating the Apps ViewModel or making network requests. The legacy services flow remains unchanged.